-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[dagster-powerbi] Use Power BI translator instance in spec loader and state-backed defs #26734
[dagster-powerbi] Use Power BI translator instance in spec loader and state-backed defs #26734
Conversation
Deploy preview for dagster-docs ready! Preview available at https://dagster-docs-iw1y2vzqv-elementl.vercel.app Direct link to changed pages: |
bfdc3dc
to
5d6da04
Compare
2274f29
to
45cdd38
Compare
22ccf98
to
adf4154
Compare
45cdd38
to
cc5f8b4
Compare
adf4154
to
88115b1
Compare
cc5f8b4
to
d3cd3cc
Compare
88115b1
to
24fe471
Compare
d3cd3cc
to
c573fea
Compare
@@ -43,7 +43,7 @@ def get_semantic_model_spec(self, data: PowerBIContentData) -> dg.AssetSpec: | |||
|
|||
power_bi_specs = load_powerbi_asset_specs( | |||
power_bi_workspace, | |||
dagster_powerbi_translator=CustomDagsterPowerBITranslator, | |||
dagster_powerbi_translator=CustomDagsterPowerBITranslator, # type: ignore |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should be unnecssary now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch, I missed it
c573fea
to
ef04d84
Compare
ef04d84
to
7faa2f0
Compare
…d state-backed defs (#26743) ## Summary & Motivation Same as #26734 but for Looker. ## How I Tested These Changes BK ## Changelog [dagster-looker] `load_looker_asset_specs` and `build_looker_pdt_assets_definitions` are updated to accept an instance of `DagsterLookerApiTranslator` or custom subclass.
… state-backed defs (#26734) ## Summary & Motivation Updates `load_powerbi_asset_specs()` and state-backed definitions to accept an instance of `DagsterPowerBITranslator`. See #26133 for more details about the motivation. ## How I Tested These Changes BK ## Changelog [dagster-powerbi] `load_powerbi_asset_specs` is updated to accept an instance of `DagsterPowerBITranslator` or custom subclass.
Summary & Motivation
Updates
load_powerbi_asset_specs()
and state-backed definitions to accept an instance ofDagsterPowerBITranslator
.See #26133 for more details about the motivation.
How I Tested These Changes
BK
Changelog
[dagster-powerbi]
load_powerbi_asset_specs
is updated to accept an instance ofDagsterPowerBITranslator
or custom subclass.