Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dagster-powerbi] Use Power BI translator instance in spec loader and state-backed defs #26734

Conversation

maximearmstrong
Copy link
Contributor

@maximearmstrong maximearmstrong commented Dec 27, 2024

Summary & Motivation

Updates load_powerbi_asset_specs() and state-backed definitions to accept an instance of DagsterPowerBITranslator.

See #26133 for more details about the motivation.

How I Tested These Changes

BK

Changelog

[dagster-powerbi] load_powerbi_asset_specs is updated to accept an instance of DagsterPowerBITranslator or custom subclass.

@maximearmstrong maximearmstrong force-pushed the maxime/move-translator-context-to-translator-props-class-powerbi branch from bfdc3dc to 5d6da04 Compare December 27, 2024 16:50
@maximearmstrong maximearmstrong force-pushed the maxime/use-translator-instance-in-load-powerbi-asset-specs branch 2 times, most recently from 2274f29 to 45cdd38 Compare December 27, 2024 16:52
@maximearmstrong maximearmstrong force-pushed the maxime/move-translator-context-to-translator-props-class-powerbi branch from 22ccf98 to adf4154 Compare December 27, 2024 17:19
@maximearmstrong maximearmstrong force-pushed the maxime/use-translator-instance-in-load-powerbi-asset-specs branch from 45cdd38 to cc5f8b4 Compare December 27, 2024 17:19
@maximearmstrong maximearmstrong force-pushed the maxime/move-translator-context-to-translator-props-class-powerbi branch from adf4154 to 88115b1 Compare December 27, 2024 19:39
@maximearmstrong maximearmstrong force-pushed the maxime/use-translator-instance-in-load-powerbi-asset-specs branch from cc5f8b4 to d3cd3cc Compare December 27, 2024 19:39
@maximearmstrong maximearmstrong self-assigned this Dec 27, 2024
@maximearmstrong maximearmstrong marked this pull request as ready for review December 27, 2024 19:59
@maximearmstrong maximearmstrong force-pushed the maxime/move-translator-context-to-translator-props-class-powerbi branch from 88115b1 to 24fe471 Compare January 2, 2025 18:27
@maximearmstrong maximearmstrong force-pushed the maxime/use-translator-instance-in-load-powerbi-asset-specs branch from d3cd3cc to c573fea Compare January 2, 2025 18:27
@@ -43,7 +43,7 @@ def get_semantic_model_spec(self, data: PowerBIContentData) -> dg.AssetSpec:

power_bi_specs = load_powerbi_asset_specs(
power_bi_workspace,
dagster_powerbi_translator=CustomDagsterPowerBITranslator,
dagster_powerbi_translator=CustomDagsterPowerBITranslator, # type: ignore
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be unnecssary now?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, I missed it

Base automatically changed from maxime/move-translator-context-to-translator-props-class-powerbi to master January 2, 2025 19:51
@maximearmstrong maximearmstrong force-pushed the maxime/use-translator-instance-in-load-powerbi-asset-specs branch from c573fea to ef04d84 Compare January 2, 2025 19:54
@maximearmstrong maximearmstrong force-pushed the maxime/use-translator-instance-in-load-powerbi-asset-specs branch from ef04d84 to 7faa2f0 Compare January 2, 2025 20:06
maximearmstrong added a commit that referenced this pull request Jan 2, 2025
…d state-backed defs (#26743)

## Summary & Motivation

Same as #26734 but for Looker.

## How I Tested These Changes

BK

## Changelog

[dagster-looker] `load_looker_asset_specs` and
`build_looker_pdt_assets_definitions` are updated to accept an instance
of `DagsterLookerApiTranslator` or custom subclass.
@maximearmstrong maximearmstrong merged commit 3f62106 into master Jan 2, 2025
2 checks passed
maximearmstrong added a commit that referenced this pull request Jan 2, 2025
… state-backed defs (#26734)

## Summary & Motivation

Updates `load_powerbi_asset_specs()` and state-backed definitions to
accept an instance of `DagsterPowerBITranslator`.

See #26133 for more details about the motivation.

## How I Tested These Changes

BK

## Changelog

[dagster-powerbi] `load_powerbi_asset_specs` is updated to accept an
instance of `DagsterPowerBITranslator` or custom subclass.
@maximearmstrong maximearmstrong deleted the maxime/use-translator-instance-in-load-powerbi-asset-specs branch January 2, 2025 20:28
maximearmstrong added a commit that referenced this pull request Jan 2, 2025
…state-backed defs (#26740)

## Summary & Motivation

Same as #26734 but for Tableau.

## How I Tested These Changes

BK

## Changelog

[dagster-tableau] `load_tableau_asset_specs` is updated to accept an
instance of `DagsterTableauTranslator` or custom subclass.
@neverett neverett added the docs-to-migrate Docs to migrate to new docs site label Jan 2, 2025
maximearmstrong added a commit that referenced this pull request Jan 3, 2025
…e-backed defs (#26799)

## Summary & Motivation

Same as #26734 but for Sigma.

## How I Tested These Changes

BK

## Changelog

[dagster-sigma] `load_sigma_asset_specs` is updated to accept an
instance of `DagsterSigmaTranslator` or custom subclass.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-to-migrate Docs to migrate to new docs site
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants